SEZ9 commented on PR #11142:
URL: https://github.com/apache/seatunnel/pull/11142#issuecomment-6842806374

   Thanks for the update. Since `095e1950` only merges the latest `dev` on top 
of `05d858e7` and the PR hunks are otherwise unchanged, the EXTRACT fix itself 
(`DateTimeFunction`, `ZetaSQLType`, `ExtractFunctionTest`, the 
`func_datetime.conf` fixture and both `incompatible-changes.md` entries) still 
looks correct, and I have no further comments on it.
   
   What remains open is unchanged from the last review:
   
   1. **Paimon E2E skip (blocking):** 
`PaimonIT#privilegeEnabledPaimonSourceUnAuthorized` is still disabled for the 
SeaTunnel engine. Please drop that change from this PR and track the possible 
Paimon hang separately.
   2. **Druid pom exclusions (blocking):** the SIGAR exclusions in 
`seatunnel-connectors-v2/connector-druid/pom.xml` are still bundled in. Please 
move them to their own PR with the justification and Druid IT evidence.
   3. Singular aliases in the `sql-functions.md` field tables and the 
duplicated EPOCH literal remain optional.
   
   **CI:** no Build has run on `095e1950` yet. Please trigger the Build 
workflow manually from your fork, or push the next commit with the fixes above, 
which will trigger it as usual.
   
   Happy to take another look once the two blockers are removed and CI has run 
on the new head.
   
   <!-- streview-comment:2312 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to