SEZ9 commented on PR #13005:
URL: https://github.com/apache/seatunnel/pull/13005#issuecomment-6842432124

   Thanks for keeping the branch in sync, @goutamadwant.
   
   Where things stand from my side:
   
   - The review of head `b5856a0b` found the PR's net diff against `dev` 
unchanged since `898d48a9` (REST submit variables, the 
`ConfigBuilder.substituteVariables` quoting via 
`ConfigMapPathUtils.quoteInvalidPathKeys`, plus the new `ConfigBuilderTest` / 
`RestSubmitJobVariablesIT` coverage), with no non-CI blockers. The failures on 
the earlier fork run `42767235465` (`SftpFileIT` image pull, 
`TiDBCDCIT.startUp`, `SeaTunnelClientTest.testSetJobIdDuplicate`, lost runner) 
were all judged unrelated to this PR, and syncing `dev` was the suggested fix. 
So the only remaining gate is a green run on the current head.
   
   - Your latest comment about normalizing successful empty Pod logs to empty 
text in polling and diagnostics doesn't match anything in this PR's diff as 
reviewed (REST variable substitution, 16 files). Could you clarify:
     1. Was that meant for a different PR, or does it correspond to a new push 
here? If it's a new push, please point me to the commit so it can be 
re-reviewed, since it would move the head again and change the scope of the 
change.
     2. If it does belong here, which files/tests cover the empty-log handling? 
The current review notes don't mention any Kubernetes/Pod code, so I want to 
make sure it's intentional and in scope for "REST submit variables" rather than 
something that should be split out.
   
   Once that's cleared up and the fork `Build` for the reviewed head is green, 
I'm happy to approve and merge.
   
   <!-- streview-comment:2310 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to