SEZ9 commented on issue #13248: URL: https://github.com/apache/seatunnel/issues/13248#issuecomment-6871246711
Thanks @goutamadwant — preparing Python in the engine images ahead of runtime startup is the right direction for this. It removes the apt-get step that PythonIT and TestPythonTransformIT currently run inside already-started containers, so test startup no longer hinges on package-mirror DNS/network access or on the Temurin base image happening to ship Python. A few concrete asks so I can review the PR you opened effectively: 1. Please confirm that both PythonIT and TestPythonTransformIT no longer invoke apt-get (or any other network-dependent install) at container runtime, and that the only remaining Python provisioning happens at image build time. 2. Could you note in the PR description how Python is baked into the image (which layer/stage) and which Python version ends up in the engine image, so we can keep it consistent across the engine variants used by the E2E tests? 3. It would help to see a run of the Python E2E tests in a network-restricted environment (or with the package mirror unreachable) to verify that startup really is independent of mirror availability now. 4. Since you mentioned it depends on the Java 17 G1 cleanup check PR, please clarify the intended merge order and whether the Python image change can be validated independently in the meantime, or whether the E2E run must wait until that dependency lands. Once those are in place I'll take a look at the PR. Thanks for picking this up. <!-- streview-comment:2350 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
