davidzollo commented on PR #12376:
URL: https://github.com/apache/seatunnel/pull/12376#issuecomment-6886005056

   ### Implementation Notes and Trade-offs
   
   Head: `b23218b3cbe2855f73b1e743b5d320742dea7009`
   
   I synced this branch with `dev` and resolved the one overlap in 
`HttpSinkBatchWriterTest.java`. The earlier failed assertions depended on the 
production fix that has now merged in #12312. The resolution keeps both tests 
from #12312 and both cases from this PR: an array-mode IOException must 
propagate without losing the batch on retry, and the HTTP client must close 
even when the final flush fails.
   
   Keeping both sets matters: accepting just one side would lose different 
failure coverage. The dev-relative change remains one test file. No production 
code or build configuration changed in the PR diff. Scoped Spotless apply/check 
and the diff whitespace check passed; the updated GitHub Build is the runtime 
verification gate.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to