SEZ9 commented on PR #10808: URL: https://github.com/apache/seatunnel/pull/10808#issuecomment-6887782021
Thanks for the update to `cf78991fa07bbd64895ba1f34bdcab62efbfef36` and for the notes on reconciling the `dev` merge. On the REST cluster-health topology fields (PR10808-F5): the distinction you describe between default unauthenticated access and the existing Basic Auth configuration sounds like it addresses the concern. Could you point me to the changed English and Chinese doc hunks so I can confirm and close it? For the remaining earlier points, I can't yet tell from the notes whether they were touched at this head. Could you confirm the status of each, or point to the relevant changes? 1. **Fallback coordinator selection in `ServerExecuteCommand` (PR10808-F1 / PR10808-F2)** — does the fallback path now resolve the server's actual active coordinator, or is the "first non-lite member" heuristic still in place? If the latter, a short note on why it's acceptable would help. 2. **Unknown coordinator in member-list output (PR10808-F6)** — when no active coordinator can be resolved, is there now an explicit "unknown" marker rather than labeling every non-lite member as `MASTER`? 3. **`incompatible-changes.md` (PR10808-F3 / PR10808-F7)** — does the entry now cover (a) the changed "ACTIVE MASTER" semantics of the CLI member list in separated clusters and (b) the standby/failover window where no node reports as active coordinator for `isMaster` / `cluster_info`? 4. **`telemetry.md` (PR10808-F4)** — does the doc now state the actual value of the "bounded timeout" for the final cancel-time metrics flush, and whether it's configurable? 5. **`ServerExecuteCommandTest` (PR10808-F8)** — minor: has the inline fully-qualified `java.util.Collections` been replaced with an import? Also, since the [Build](https://github.com/davidzollo/seatunnel/actions/runs/43654793096) was still in progress, please share the result once it finishes, including whether the persisted-DAG recovery test passes with the differing old/active coordinator address. Happy to do another pass once those are in. <!-- streview-comment:2353 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
