SEZ9 commented on PR #11493:
URL: https://github.com/apache/seatunnel/pull/11493#issuecomment-6888835931

   Thanks for the follow-up on `e4d826fb702dad3ed3571c6e4e09a841f433c035`. The 
notes there focus on the TEXT fixture and the still-open Doris/LocalFile 
checks, so from my side the four points from the earlier review are still 
outstanding. Summarizing what I'd like to see before I can approve:
   
   1. **Source type change with no opt-out (HIGH)** – Snowflake `VARIANT`, 
Doris `JSON`/`JSONB` and StarRocks `JSON` columns now surface as the new JSON 
logical type instead of `STRING` on upgrade. Please either add an option that 
keeps the previous `STRING` mapping, or make an explicit case in 
`docs/en/introduction/concepts/incompatible-changes.md` for why a silent change 
is acceptable and what users with existing pipelines must do. The current 
wording in the compatibility note documents the shift but does not give users a 
migration path.
   
   2. **No JSON validation on the logical type (MEDIUM)** – since `JSON_TYPE` 
is physically a `String`, non-JSON text can flow all the way to a native JSON 
sink and only fail at the StarRocks load boundary. Please clarify in 
`docs/en/introduction/concepts/schema-feature.md` whether validation is 
intentionally the sink's responsibility, and if so, where each native JSON sink 
enforces it. If there is a central validation point I missed, point me to it.
   
   3. **StarRocks CSV Stream Load + native JSON columns (MEDIUM)** – the 
rejection should be a fail-fast check at sink initialization rather than a 
load-time error. Please add that check and document the constraint in 
`docs/en/connectors/sink/StarRocks.md`.
   
   4. **Snowflake sink with user-defined query (MEDIUM)** – skipping 
`PARSE_JSON` wrapping silently defers failure to a server-side error mid-run. 
Either wrap JSON fields in the custom-query path as well, or fail fast/warn at 
initialization and document the limitation in 
`docs/en/connectors/sink/Snowflake.md`.
   
   Two smaller asks tied to the above: the follow-up states that no local 
compile, runtime or E2E validation was run on this head, so please confirm once 
the CI on `e4d826fb702dad3ed3571c6e4e09a841f433c035` is green and add E2E 
coverage for points 3 and 4 (misconfigured StarRocks CSV + JSON column, 
Snowflake custom query with a JSON field). Also, the self-review at 
`a645c856a90a37473a34d83ac5b9f5e91a8d1116` mentions that the Doris storage and 
upgrade-consumption checks are still open—please share the result of those once 
done, as they feed directly into point 1.
   
   Happy to take another look as soon as these are pushed.
   
   <!-- streview-comment:2362 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to