SEPURI-SAI-KRISHNA commented on PR #13222: URL: https://github.com/apache/seatunnel/pull/13222#issuecomment-6907703420
@DanielLeens Thanks, I took both suggestions in `73d241e96c`. 1. `incompatible-changes.md` (EN and ZH), Impact: a source response with both `data` and a non-empty `errors` array, which was read as rows with `null` in the failed fields, now fails the job, and there is no option to keep the old behavior; in the streaming HTTP query mode, one poll answered with errors now fails the task, where that poll used to produce no rows. The migration guide now also names the permissions on the server. I left a tolerate-partial-errors option out, as you suggested. 2. `GraphQLIT.startUp` tracks each table in its own `untilAsserted`, so once `source` is tracked, a retry only tracks `sink`. The push dismisses your approval, sorry for the extra round; the code under review is unchanged apart from the test setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
