DanielLeens commented on issue #13217: URL: https://github.com/apache/seatunnel/issues/13217#issuecomment-6915923612
Thanks — this is the right direction for the STIP draft. I agree that the design must decide the target behavior, not merely turn a source expression into a string of DDL. A current-dev recheck at `afbdd0d4c2851b7621dc02d78396b431ec8a79f6` still shows the untyped `Column.defaultValue` contract and the JDBC schema-evolution path deliberately limits default rendering to the same dialect. Please make the STIP explicit and testable on these points: 1. **Additive compatibility.** Keep the new representation beside the existing field in v1, and enumerate constructor, copy, schema-event and serialized/catalog-metadata behavior for old values. In particular, distinguish absent default from a literal `NULL`; neither may be reinterpreted during replay or upgrade. 2. **Closed v1 semantics.** Name the exact literal types and current-time expressions in the catalog. Anything outside it must have a defined stored form but must never become guessed target SQL. 3. **Failure policy.** A default schema operation should fail when a requested default is unsupported. If a future opt-in drop-and-continue policy is proposed, specify its configuration contract, observable warning/metric, and resulting target-schema state; it cannot be a silent fallback. 4. **Bounded first delivery.** State one named MySQL source/target pair and the auto-create path as the initial slice. Include target DDL assertions for escaped strings, numeric/decimal values, absent versus `NULL`, current-time defaults, and a metadata/replay compatibility case. CDC evolution and cross-dialect mapping remain later design decisions. Please post the dev@ discussion and link the resulting `[STIP-N]` issue here. Once that design has maintainer consensus, it will provide the acceptance contract for a small implementation PR; please do not open the implementation PR before then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
