CryoThrust commented on PR #12744:
URL: https://github.com/apache/seatunnel/pull/12744#issuecomment-6919707881

   Addressed the remaining clock-stability suggestion as well. The public 
constructor still uses `System.currentTimeMillis`; a package-private supplier 
overload lets the unit cases check exact per-row timestamps, including a 
two-hour backwards step, for both an absent time key and the null-value 
fallback at all six precisions.
   
   The InfluxDB readback case now compares the stored processing timestamp with 
the actual serialized point after precision conversion. The fixed LocalDateTime 
assertion still uses its independent expected instant. Neither check brackets 
system wall time, and no assertion is skipped on clock discontinuity.
   
   All 79 connector unit tests and all six selected real InfluxDB 1.8 readback 
cases pass on JDK 11, with no failures/errors/skips. Both modules pass 
Spotless, Checkstyle and packaging/verify. The earlier EN/ZH migration notes 
and helper contracts remain in place, so all three items from the latest review 
are addressed. The readback selection is serializer/client/database coverage, 
not a full engine-job E2E run.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to