SEZ9 commented on PR #12149: URL: https://github.com/apache/seatunnel/pull/12149#issuecomment-6936378711
@CryoThrust thanks for the detailed breakdown of the old-head Build and for syncing `dev` (`37309e1a8`) in `036319a35`. From your log summary, the five failed connector jobs (the SFTP image 404 on JDK 11 and 17, the `TiDBCDCIT.startUp` communications-link error, and the `JdbcIrisIT` startup timeouts on JDK 11 and 17) are all fixture or database startup failures. The four unit jobs and both engine-v2/resource-manager JDK lanes passed. I agree with keeping connector workarounds out of this PR and holding the change to the three checkpoint files. The earlier review found no blocking source issue on head `1846ff8c63f439483156cfd51be68b68ed7fe3cb`, and the open gate was a real exact-head Build run. Since the head has moved with the sync, the remaining asks are: 1. **New-head Build:** please post the final result of [the new-head Build](https://github.com/CryoThrust/seatunnel/actions/runs/44003200554) once it finishes, and confirm it ran against the current PR head. 2. **Sync commit:** did `036319a35` need any conflict resolution in the three checkpoint files, or was it a clean merge? If anything was resolved by hand, please point out those hunks so they can be re-checked. 3. **SFTP and TiDB:** if either still fails on the new head despite the fixes now pulled in from `dev`, please share the relevant log excerpt. 4. **IRIS:** the startup cause is still not established. If `JdbcIrisIT` fails again, please paste the IRIS startup errors from the log so we can judge whether it is independent of this change. Good to hear that all 19 `CheckpointCoordinatorTest` cases and the streaming master-failover IT pass locally on the new head. CI still needs the finished exact-head run and will not be passed by inference. <!-- streview-comment:2394 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
