zephyr45 commented on PR #13060: URL: https://github.com/apache/seatunnel/pull/13060#issuecomment-6948532766
@SEZ9 Opened #13298 for coordinated legacy-prefix cleanup, including owner failure, mixed prefixes and retry costs. For `7c272c5a`: - **F1:** The connector accepts the states Flink assigns, without a modulo-owner check; the [contiguous scale-down regression](https://github.com/apache/seatunnel/blob/7c272c5a246e617bff1f737fa4e78ed3a1ab7bf5/seatunnel-connectors-v2/connector-kafka/src/test/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriterTest.java#L140-L159) passes. This is model coverage, not a real Flink savepoint/rescale run. - **F2:** Yes, each saved ID is parsed against its own prefix; the [mixed generated-prefix restore test](https://github.com/apache/seatunnel/blob/7c272c5a246e617bff1f737fa4e78ed3a1ab7bf5/seatunnel-connectors-v2/connector-kafka/src/test/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriterTest.java#L227-L251) passes with `transaction_prefix` unset. - **F4:** Retry identity is fixed: the [broker test](https://github.com/apache/seatunnel/blob/7c272c5a246e617bff1f737fa4e78ed3a1ab7bf5/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/java/org/apache/seatunnel/e2e/connector/kafka/KafkaIT.java#L2400-L2460) passes for task IDs 99→100 sharing partition index 0, fencing the abandoned sequence-1 transaction and unblocking `read_committed`. Later transactions missing from retained state still have the accepted F3 timeout boundary. - **F7:** Yes: [EN option row and semantics](https://github.com/apache/seatunnel/blob/7c272c5a246e617bff1f737fa4e78ed3a1ab7bf5/docs/en/connectors/sink/Kafka.md#L66-L108) and [ZH](https://github.com/apache/seatunnel/blob/7c272c5a246e617bff1f737fa4e78ed3a1ab7bf5/docs/zh/connectors/sink/Kafka.md#L63-L104) agree on the ID shape, stateful Zeta/Flink recovery scope and Spark restrictions. These are the unchanged-head results from the November 15–16 validation. No new code revision was needed for these points. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
