lxcxjxhx commented on PR #13119: URL: https://github.com/apache/seatunnel/pull/13119#issuecomment-6967378508
All three points are addressed in `7147d7c3`, and one of them turned out to be worse than a wording problem. | your point | what I found | change | |---|---|---| | 15 relative source links only resolve in GitHub rendering | correct — and `features/multi-table.md` did not need them at all (below) | the 12 that remain are now absolute `blob/dev` URLs | | description claims "0 pages with en/zh source-link drift" | correct, it does not hold | description rewritten; the page that still drifts is named in it | | placeholder sentence in zh `multi-table.md` | the whole added block was a duplicate | that file is now untouched by this PR | **On `multi-table.md`.** Checking `dev` before editing: the two subsections this PR added (`关键源码文件` with `MultiTableSink`/`SinkIdentifier`/`TablePath`, and `示例实现`) already exist there at lines 519-528. So the addition did not fill a gap — it repeated content, and it also moved `如需进一步了解 Schema、Sink 语义与 DAG 执行…` away from the end of the page, which is why that sentence reads as a placeholder. Removing the block resolves your point and drops the file from the diff entirely. **On link form.** I went with absolute URLs since you offered them and `@davidzollo` has not stated a preference yet. If the project prefers a different form — a version tag instead of `dev`, or a docs-site path — it is a one-line rewrite of the same 12 targets, no restructuring. **Also changed, not asked for:** `engine-architecture.md` listed three package directories as backticked paths while its en counterpart names five classes. Those five are now links in the same form, so the page is not the odd one out in this set. **Verification:** every distinct URL added here returns 200 (`curl -I`, 14/14 — three of the 17 rows are the same class linked from two pages). The docusaurus build is still the one thing I cannot run here. **Still open, and deliberately not in this PR:** zh `api-design/source-architecture.md` has no `Code References` section at all, while en has four `.java` links under `3.4`. Adding a section to a page that never had one is a structural choice, so it belongs in its own PR rather than this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
