SEPURI-SAI-KRISHNA commented on PR #13308:
URL: https://github.com/apache/seatunnel/pull/13308#issuecomment-6983627505

   @DanielLeens Thanks for the review. On the resolver-level assertion: dev has 
no resolver test for MySQL yet. #13297 adds the first one, 
`MySqlSchemaChangeResolverColumnCaseTest`, which runs a DDL record through 
`MySqlSchemaChangeResolver` and applies the event with 
`AlterTableSchemaEventHandler`. To keep the two PRs free of a shared file, this 
PR leaves the completion to the IT: in `MysqlCDCWithSchemaChangeIT` the sink 
runs `CHANGE COLUMN add_column add_column_renamed INT NOT NULL DEFAULT 1`, so 
the type, nullability and default come from the completed event, and the rows 
after the rename keep their values. Whichever of the two PRs merges second will 
add a `RENAME COLUMN` case to that test class.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to