SEPURI-SAI-KRISHNA commented on issue #13318: URL: https://github.com/apache/seatunnel/issues/13318#issuecomment-6985878166
I'd like to work on the part that is not covered yet: `SinkFlowLifeCycle.close()` calls `writer.close()` while the writer is still null before the restore arrives. #12391 (for #12231) already makes `SeaTunnelTask.close()` keep closing the other lifecycles when one close throws, so this change leaves that method to it. Plan: when no writer was created, `SinkFlowLifeCycle.close()` skips the writer and the steps that need it and still closes the rest, with a unit test that closes a sink lifecycle before its restore and checks that no exception is thrown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
