SEZ9 commented on issue #13296:
URL: https://github.com/apache/seatunnel/issues/13296#issuecomment-6991996329

   @SEPURI-SAI-KRISHNA Thanks for the detailed write-up. You didn't ask a 
question, so here is where I stand on what you described.
   
   - **Where the fix lives:** Resolving the names in the MySQL-CDC resolver 
rather than in `AlterTableSchemaEventHandler` makes sense to me, for the reason 
you give. A case-insensitive handler would affect sources where column names 
can legitimately differ only in case.
   - **The hook:** A `resolveColumnName` hook in `AbstractSchemaChangeResolver` 
that keeps the parsed name by default, with `MySqlSchemaChangeResolver` mapping 
to the matching table column and keeping the table's spelling, fits the problem 
reported here. It keeps the schema in step with what Debezium records.
   - **Test coverage:** It's good that 
`MySqlSchemaChangeResolverColumnCaseTest` covers all six DDL cases, including 
the three that raised no error (`DROP COLUMN Name`, `MODIFY COLUMN NAME 
VARCHAR(128)`, `CHANGE COLUMN name NAME VARCHAR(128)`). Those silent ones were 
the most worrying part of this issue. The comparison against Debezium's own 
table model after each statement is a useful guard too.
   
   I haven't verified the change or the test results myself yet; this is based 
on your description. I have nothing further to ask of you on this issue, and 
the code-level review will continue on the PR you linked.
   
   <!-- streview-comment:2430 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to