SEZ9 commented on PR #13329:
URL: https://github.com/apache/seatunnel/pull/13329#issuecomment-7023074415

   @SEPURI-SAI-KRISHNA thanks for reading the full diff at `69f562a5ca` and the 
STIP context.
   
   **Scope vs. STIP-41.** I can't confirm this on behalf of the #12457 
reviewers. My earlier review did not cover the STIP scope, so whether Kerberos 
and in-place named snapshots belong in this PR or in follow-ups needs an 
explicit answer from them.
   
   **Hazelcast trust boundary.** Agreed, and your `ps` point is a good one. If 
a per-application secret is added, it should not be passed the way the cluster 
name is today, as a worker command-line argument in `WorkerContainerFactory`. 
Container credentials or a localized file both work for me, as long as the 
secret also stays out of the RM application report. This point is still open: 
the AM publishes an unauthenticated Hazelcast endpoint through that report.
   
   **Status cleanup.** Could you confirm which case you saw fixed in the last 
commit? The one I raised is a failed AM unregistration being retried in 
`close()` with a hard-coded `FAILED` status, so a job that SUCCEEDED or was 
CANCELED can be published to YARN as FAILED. If that is the one, a pointer to 
the change would let me close it out.
   
   **Kerberos limits.** Your point 2 is cut off after 
"`YarnSecurityContext.masterTokens` gets tokens for the staging file". Could 
you repost the rest?
   
   I have not seen replies in this thread on the other items from my earlier 
review, so they still stand as asked:
   - Setting `yarn.master.http-port` forces plaintext HTTP, overriding 
`enable-https` while basic auth is kept.
   - `closeDriverIfNeeded()` is unguarded in `runJob`'s finally block, ahead of 
`master.shutdown()`.
   - The AM entry point and `startMaster()` catch only `Exception`, so an 
`Error` bypasses them.
   - The submitter's full Hadoop `Configuration` is localized into every 
container.
   - The documented `yarn.config-dir` fallback to the Hadoop classpath is not 
reachable with the shipped launcher.
   
   <!-- streview-comment:2456 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to