SEZ9 commented on issue #12923:
URL: https://github.com/apache/seatunnel/issues/12923#issuecomment-7023266870

   @taozhiyi13 Thanks for laying this out. One complete PR organized into three 
dependency-ordered commits works for me, subject to the outcome of the `dev@` 
discussion.
   
   Your reasoning holds: the API and CDC slices have no standalone user-facing 
value without the Elasticsearch/OpenSearch sink. A single PR also lets the full 
`MySQL-CDC -> Zeta -> Elasticsearch/OpenSearch` E2E suite run before anything 
is merged.
   
   The three boundaries you listed are the right ones to review against:
   
   1. Shared API and engine contract
   2. MySQL-CDC source
   3. Elasticsearch/OpenSearch sink
   
   Remaining asks from my side:
   
   - **Keep the commits separable.** Please keep the three commits aligned with 
the STIP slices through the review rounds, so they can still be reviewed commit 
by commit. That also means they can be lifted into stacked PRs unchanged if 
`dev@` prefers that model.
   - **Post the `dev@` outcome here.** As you said, please report the final 
mailing-list result on this issue. That result decides the delivery model, not 
my preference alone.
   - **Keep the implementation on hold until then.** As you noted earlier, it 
waits until the discussion reaches consensus and the STIP is accepted.
   
   Nothing else is needed from you on the delivery question for now.
   
   <!-- streview-comment:2459 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to