DanielLeens commented on PR #13312:
URL: https://github.com/apache/seatunnel/pull/13312#issuecomment-7037844550

   Thanks, @BryanOnKeys, for checking the generated SQL and bindings with an 
exact-row fixture. The boundary/NULL/once-only assertions are useful evidence 
and fit the regression requested in my existing review. They do not yet replace 
an executed SeaTunnel JDBC-source integration path: please move the scenario 
into the existing connector IT, covering NULL rows, the explicit lower/upper 
bounds and adjacent splits, and assert the complete expected row set without 
duplicates.
   
   My existing integration-coverage blocker remains open until the test is 
committed. I am not asking for an unrelated split-planner redesign, and no fix 
is confirmed from a standalone SQL experiment alone.
   
   Checked unchanged head `138045a6b06e996f833f57afa13bcf4bede92ced` against 
`dev`: compare `diverged`, ahead 1 / behind 11. This drift is recorded 
independently; it does not by itself request synchronization. This is a 
discussion/CI follow-up, not another full source review. No local build, test 
or runtime execution was performed. Daniel has READ repository permission; 
effective maintainer approval/dismissal remains a separate repository gate. 
Checked 2026-11-20T11:59:57.811808+00:00.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to