Repository: sentry Updated Branches: refs/heads/master 535e186fc -> 1c77f5d3b
SENTRY-2167: Change ignored logging messages to debug level in NotificationProcessor (kalyan kumar kalvagadda, reviewed by Sergio Pena, Xinran Tinney) Change-Id: Ie349de78bcc862efd70a211a5d868977c0e4f7a5 Project: http://git-wip-us.apache.org/repos/asf/sentry/repo Commit: http://git-wip-us.apache.org/repos/asf/sentry/commit/1c77f5d3 Tree: http://git-wip-us.apache.org/repos/asf/sentry/tree/1c77f5d3 Diff: http://git-wip-us.apache.org/repos/asf/sentry/diff/1c77f5d3 Branch: refs/heads/master Commit: 1c77f5d3bdba0a6327e6bbe87abf542610f50f06 Parents: 535e186 Author: kalyan kumar kalvagadda <[email protected]> Authored: Tue Apr 17 10:26:22 2018 -0500 Committer: Sergio Pena <[email protected]> Committed: Tue Apr 17 10:26:22 2018 -0500 ---------------------------------------------------------------------- .../provider/db/service/persistent/NotificationProcessor.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/sentry/blob/1c77f5d3/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java ---------------------------------------------------------------------- diff --git a/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java b/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java index 90bc1cc..96fe413 100644 --- a/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java +++ b/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java @@ -408,7 +408,7 @@ final class NotificationProcessor { try { renamePrivileges(oldDbName, oldTableName, newDbName, newTableName); } catch (SentryNoSuchObjectException e) { - LOGGER.info("Rename Sentry privilege ignored as there are no privileges on the table:" + LOGGER.debug("Rename Sentry privilege ignored as there are no privileges on the table:" + " {}.{}", oldDbName, oldTableName); } catch (Exception e) { LOGGER.info("Could not process Alter table event. Event: {}", event.toString(), e); @@ -688,6 +688,7 @@ final class NotificationProcessor { updateAuthzPathsMapping(oldAuthzObj, oldPathTree, newAuthzObj, newPathTree,event); } } else { + // This code should not be hit as appropriate checks are performed by the callers of this method. LOGGER.error("Update Notification for Auhorizable object {}, with no change, skipping", oldAuthzObj); throw new SentryInvalidHMSEventException("Update Notification for Authorizable object" @@ -735,7 +736,7 @@ final class NotificationProcessor { authorizable.setDb(dbName); sentryStore.dropPrivilege(authorizable, getPermUpdatableOnDrop(authorizable)); } catch (SentryNoSuchObjectException e) { - LOGGER.info("Drop Sentry privilege ignored as there are no privileges on the database: {}", + LOGGER.debug("Drop Sentry privilege ignored as there are no privileges on the database: {}", dbName); } catch (Exception e) { LOGGER.error("Could not process Drop database event." + "Event: " + event.toString(), e); @@ -750,7 +751,7 @@ final class NotificationProcessor { authorizable.setTable(tableName); sentryStore.dropPrivilege(authorizable, getPermUpdatableOnDrop(authorizable)); } catch (SentryNoSuchObjectException e) { - LOGGER.info("Drop Sentry privilege ignored as there are no privileges on the table: {}.{}", + LOGGER.debug("Drop Sentry privilege ignored as there are no privileges on the table: {}.{}", dbName, tableName); } catch (Exception e) { LOGGER.error("Could not process Drop table event. Event: " + event.toString(), e);
