[ 
https://issues.apache.org/jira/browse/SENTRY-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780218#comment-13780218
 ] 

Shreepadma Venugopalan commented on SENTRY-4:
---------------------------------------------

The patch still doesn't apply,

{noformat}

patch -p0 < SENTRY-4v3.patch 
patching file 
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java
Hunk #1 succeeded at 127 (offset 1 line).
patching file 
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java
patching file 
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java
Hunk #1 succeeded at 79 (offset 3 lines).
patching file 
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzConf.java
patching file 
sentry-binding/sentry-binding-hive/src/test/resources/access-site.xml
patching file 
sentry-binding/sentry-binding-hive/src/test/resources/sentry-site.xml
patching file sentry-tests/sentry-tests-hive/src/test/resources/sentry-site.xml

{noformat}
                
> Rename Configuration properties that mention hive but are sentry related
> ------------------------------------------------------------------------
>
>                 Key: SENTRY-4
>                 URL: https://issues.apache.org/jira/browse/SENTRY-4
>             Project: Sentry
>          Issue Type: Improvement
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>         Attachments: SENTRY-4.patch, SENTRY-4v2.patch, SENTRY-4v3.patch
>
>
> I'm thinking of the following properties, I'll check if there are others:
> hive.sentry.provider -> sentry.provider
> hive.sentry.provider.resource -> sentry.provider.resource
> hive.sentry.server -> sentry.server
> I'm happy to implement this, just need some guidance on what you want to do 
> about compatibility.
> I was thinking the following:
> 1) If only old names used: accept old values, log warning
> 2) If old and new names used: use new values, log warning about old names 
> being ignored
> 3) If only old new names used: use new values, no log warning
> Thoughts?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to