[
https://issues.apache.org/jira/browse/SENTRY-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784209#comment-13784209
]
Brock Noland commented on SENTRY-17:
------------------------------------
Hey it looks like you created the patch with --no-prefix? Let's not do that
since we are using git as our primary source control.
But mainly the issue is that the patch won't apply:
git apply -p0 < SENTRY-17v3.patch
fatal: git apply: bad git-diff - inconsistent old filename on line 129
> Separate sentry-provider to hive specific and non-specific packages
> -------------------------------------------------------------------
>
> Key: SENTRY-17
> URL: https://issues.apache.org/jira/browse/SENTRY-17
> Project: Sentry
> Issue Type: Sub-task
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Attachments: SENTRY17v2.patch, SENTRY-17v3.patch
>
>
> SENTRY-9 suggests moving the GroupMappingService to core. I'm thinking of
> just moving it to a sentry-provider-common package, which will eventually
> contain what the non-trivial authorization providers need. That way core is
> just really core model/authorizable/action related code.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
