[ 
https://issues.apache.org/jira/browse/SENTRY-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992876#comment-13992876
 ] 

Jarek Jarcec Cecho commented on SENTRY-57:
------------------------------------------

The patch no longer applies cleanly on {{trunk}}. Would you mind rebasing it 
[~sravya]?

> Make tests in TestURIPermissions more restrictive
> -------------------------------------------------
>
>                 Key: SENTRY-57
>                 URL: https://issues.apache.org/jira/browse/SENTRY-57
>             Project: Sentry
>          Issue Type: Improvement
>            Reporter: Sravya Tirukkovalur
>            Assignee: Sravya Tirukkovalur
>            Priority: Minor
>         Attachments: SENTRY-57.2.patch, SENTRY-57.patch
>
>
> Some minor improvements
> - Fix the role names: for example role "server=server1->db=" + dbName + 
> "->table=" + tabName + "->action=INSERT" should not be named db1_write, 
> instead it should be "tab1_write"
> - Make the positive tests permissions more restrictive. For example, if a 
> select permission on URI is required for a command. Make sure to give SELECT 
> instead of ALL.
> - Comment each test with the command and permissions required, so that we can 
> directly create documentation from here.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to