[
https://issues.apache.org/jira/browse/SENTRY-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073928#comment-14073928
]
Gregory Chanan commented on SENTRY-362:
---------------------------------------
[~guoquan] I looked at the latest patch. Looks good! Two comments:
1. Why did SolrAuthzConf change from super(false) to super(true) -- can you
explain why this is necessary?
2. getAuthProvider(Configuration authzConf) takes an authzConf, but doesn't
really use it (for example, getConf just uses the saved Configuration field
rather than the parameter). We should either remove this parameter and always
use the saved field, or use it consistently, and give it a different name from
the field.
> When sentry integrate into solr, the create instance of backend needs
> configure parameters from solrAuthzConf not hadoopConf
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: SENTRY-362
> URL: https://issues.apache.org/jira/browse/SENTRY-362
> Project: Sentry
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: guoquanshen
> Assignee: guoquanshen
> Attachments: SENTRY-362.patch, SENTRY-362.patch
>
>
> whatever Sentry Solr plugin integration with db store or file store, the
> create instance of DBProviderBackend of FIleProviderBackend should get the
> configuration from sentry-site.xml not hadoop configuration. The following
> code isn't correct:
> {code:title=SolrAuthzBinding.java}
> Configuration conf = getConf();
> providerBackend =(ProviderBackend)
> providerBackendConstructor.newInstance(new Object[] {conf, resourceName});
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
