[ 
https://issues.apache.org/jira/browse/SENTRY-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082976#comment-14082976
 ] 

Sravya Tirukkovalur commented on SENTRY-346:
--------------------------------------------

Thanks for the patch [~colinma]! And thanks for the review [~prasadm]! +1 LGTM. 
[~colinma], the patch doesnt seem to apply cleanly for me. Can you please check 
it?

> Create new FileAppender used in log4j to keep all the logs
> ----------------------------------------------------------
>
>                 Key: SENTRY-346
>                 URL: https://issues.apache.org/jira/browse/SENTRY-346
>             Project: Sentry
>          Issue Type: Sub-task
>    Affects Versions: 1.4.0
>            Reporter: Colin Ma
>            Assignee: Colin Ma
>         Attachments: sentry-346.v1.patch
>
>
> The audit log will be generated by log4j. Currently, the RollingFileAppender 
> deletes logs after rolling over certain number of time(according to 
> MaxBackupIndex property). In order to keep all audit logs, there need a new 
> FileAppender.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to