[ 
https://issues.apache.org/jira/browse/SENTRY-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084201#comment-14084201
 ] 

Colin Ma edited comment on SENTRY-346 at 8/4/14 1:21 AM:
---------------------------------------------------------

hi [~sravya], thanks for review. A new FileAppender for log4j is implemented in 
this patch. For this new FileAppender, we can do the configuration in the 
log4j.properties, eg:
    log4j.logger.sentry.hive.authorization.ddl.logger=INFO, sentryAudit 
    
log4j.appender.sentryAudit=org.apache.sentry.provider.db.log.appender.RollingFileWithoutDeleteAppender
    log4j.appender.sentryAudit.File=/var/log/sentry/sentryAudit.log
    log4j.appender.sentryAudit.MaxFileSize=5MB 
    log4j.appender.sentryAudit.layout=org.apache.log4j.PatternLayout 
    log4j.appender.sentryAudit.layout.ConversionPattern=%m%n

The Navigator in CDH want to keep all audit logs, and the new 
FileAppender(RollingFileWithoutDeleteAppender)  is implemented for this 
purpose. Any comments are welcome, thanks.


was (Author: colinma):
hi @sravya, thanks for review. A new FileAppender for log4j is implemented in 
this patch. For this new FileAppender, we can do the configuration in the 
log4j.properties, eg:
    log4j.logger.sentry.hive.authorization.ddl.logger=INFO, sentryAudit 
    
log4j.appender.sentryAudit=org.apache.sentry.provider.db.log.appender.RollingFileWithoutDeleteAppender
    log4j.appender.sentryAudit.File=/var/log/sentry/sentryAudit.log
    log4j.appender.sentryAudit.MaxFileSize=5MB 
    log4j.appender.sentryAudit.layout=org.apache.log4j.PatternLayout 
    log4j.appender.sentryAudit.layout.ConversionPattern=%m%n

The Navigator in CDH want to keep all audit logs, and the new 
FileAppender(RollingFileWithoutDeleteAppender)  is implemented for this 
purpose. Any comments are welcome, thanks.

> Create new FileAppender used in log4j to keep all the logs
> ----------------------------------------------------------
>
>                 Key: SENTRY-346
>                 URL: https://issues.apache.org/jira/browse/SENTRY-346
>             Project: Sentry
>          Issue Type: Sub-task
>    Affects Versions: 1.4.0
>            Reporter: Colin Ma
>            Assignee: Colin Ma
>         Attachments: sentry-346.v1.patch
>
>
> The audit log will be generated by log4j. Currently, the RollingFileAppender 
> deletes logs after rolling over certain number of time(according to 
> MaxBackupIndex property). In order to keep all audit logs, there need a new 
> FileAppender.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to