[
https://issues.apache.org/jira/browse/SENTRY-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103774#comment-14103774
]
SentryQA commented on SENTRY-396:
---------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12663088/SENTRY-396.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-SENTRY-Build/262/console
This message is automatically generated.
> The Thrift multiplexedProcessor registers mutil processor failed
> ----------------------------------------------------------------
>
> Key: SENTRY-396
> URL: https://issues.apache.org/jira/browse/SENTRY-396
> Project: Sentry
> Issue Type: Bug
> Affects Versions: 1.4.0
> Reporter: guoquanshen
> Assignee: guoquanshen
> Fix For: 1.5.0
>
> Attachments: SENTRY-396.patch
>
>
> The sentry service uses multiplexedProcessor to register multi processor, but
> the logic isn't correct in my opinion. It use processFactory to register and
> the source code as following:
> {code}TMultiplexedProcessor processor = new TMultiplexedProcessor();
> boolean registeredProcessor = false;
> for (String processorFactory : processorFactories){
> ProcessorFactory factory = (ProcessorFactory) #create factory instance
> with processorFactory name
> registeredProcessor = registeredProcessor ||
> factory.register(processor);
> }{code}
> If the first factory register successfully, registeredProcessor will become
> true then the following factories don't get the chance to register
--
This message was sent by Atlassian JIRA
(v6.2#6252)
