[ 
https://issues.apache.org/jira/browse/SENTRY-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138161#comment-14138161
 ] 

Sravya Tirukkovalur commented on SENTRY-359:
--------------------------------------------

+1, LGTM. 
One minor comment: I think we should also add test cases where our roleset/ 
groups are a subset of available ones. So that we can actually make sure they 
are being filtered out? Please feel free to file a follow on jira if you agree. 
Thanks!

> Support Sentry service API to retrieve applicable privileges for a given 
> authorizable object
> --------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-359
>                 URL: https://issues.apache.org/jira/browse/SENTRY-359
>             Project: Sentry
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Prasad Mujumdar
>            Assignee: Prasad Mujumdar
>         Attachments: SENTRY-359-noThrift.1.patch, 
> SENTRY-359-noThrift.2.patch, SENTRY-359-noThrift.3.patch, SENTRY-359.1.patch, 
> SENTRY-359.2.patch, SENTRY-359.3.patch
>
>
> The current implementation of list_sentry_privileges_for_provider is 
> specifically to facilitate Sentry auth engine. It's not intended to be a 
> general purpose metadata query.
> We should add a new API that returns the list of privileges 
> (TSentryPrivilege)  for the give authorizable object and all it's applicable 
> privileges. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to