[
https://issues.apache.org/jira/browse/SENTRY-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140181#comment-14140181
]
Dapeng Sun commented on SENTRY-380:
-----------------------------------
Hi Sravya, I created a jira relate this, please look into SENTRY-448, thank
you. You can also merge SENTRY-448 into your patch.
> Clean up some grantorPrincipal semantics
> ----------------------------------------
>
> Key: SENTRY-380
> URL: https://issues.apache.org/jira/browse/SENTRY-380
> Project: Sentry
> Issue Type: Bug
> Affects Versions: 1.4.0
> Reporter: Sravya Tirukkovalur
> Assignee: Sravya Tirukkovalur
> Fix For: 1.5.0
>
> Attachments: SENTRY-380.0.patch, SENTRY-380.1.patch,
> SENTRY-380.2.patch
>
>
> Came from SENTRY-327 review:
> - I do not think grantorPrincipal is required for createRole, we should
> instead pass it for alterSentryRoleGrantPrivilege and
> alterSentryRoleRevokePrivilege?
> - As we pass grantorPrincipal as the user invoking the thrift
> request(requestorUserName), we may keep it consistent and avoid possibility
> of passing different requestorUserName and grantorPrincipal by getting rid of
> grantorPrincipal field in the TSentryPrivilege and TSentryRole?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
