[
https://issues.apache.org/jira/browse/SENTRY-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224145#comment-14224145
]
Lenni Kuff commented on SENTRY-544:
-----------------------------------
Thanks [~sravya]. A few comments:
* PathsUpdate.java L79 - While you are here can you comment on behavior of this
function and also on return value (when would it return null). Should this
method be called parsePath instead of cleanPath?
* PathsUpdate.java L82 - Are we guaranteed that all paths will have a scheme?
If so, add a Preconditions check. If not, you need to handle this.
* TestHDFSIntegration.java L475 - Comment on what this is testing. Also
consider renaming the test to something more descriptive (testNonHdfsLocations?)
* TestHDFSIntegration.java - Add test case for db with non-HDFS path and
partition with non-HDFS path. It might also be interesting to verify ALTER SET
LOCATION works properly across moving from HDFS to non-HDFS paths and vice
versa.
> Do not add non HDFS path updates in Hive meta store Sentry plugin for HDFS
> sync
> -------------------------------------------------------------------------------
>
> Key: SENTRY-544
> URL: https://issues.apache.org/jira/browse/SENTRY-544
> Project: Sentry
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Sravya Tirukkovalur
> Assignee: Sravya Tirukkovalur
> Fix For: 1.5.0
>
> Attachments: SENTRY-544.1.patch
>
>
> In HDFS sentry plugin we strip off the file system/schema/authority and just
> retain the file path assuming it is on HDFS. But right now we are still
> adding the non HDFS file path updates as well to the table - path updates. We
> need to escape these updates in Hive meta store sentry plugin.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
