[
https://issues.apache.org/jira/browse/SENTRY-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243582#comment-14243582
]
Hadoop QA commented on SENTRY-576:
----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12686742/SENTRY-576.001.patch
against master.
{color:red}Overall:{color} -1 due to 4 errors
{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceIntegration
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceIntegration
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceIntegration
Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/179/console
This message is automatically generated.
> Remove useless logic of grant privilege
> ---------------------------------------
>
> Key: SENTRY-576
> URL: https://issues.apache.org/jira/browse/SENTRY-576
> Project: Sentry
> Issue Type: Bug
> Reporter: Xiaomeng Huang
> Assignee: Xiaomeng Huang
> Attachments: SENTRY-576.001.patch
>
>
> Every time when we grant privilege, we will do
> {code}
> MSentryPrivilege mPrivilege = alterSentryRoleGrantPrivilegeCore(pm, roleName,
> privilege);
> if (mPrivilege != null) {
> convertToTSentryPrivilege(mPrivilege, privilege);
> }
> {code}
> After grant privilege, "convertToTSentryPrivilege" is useless except waste of
> time.
> In fact, the return of "alterSentryRoleGrantPrivilegeCore" is useless, so I
> change it's return to void.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
