[ 
https://issues.apache.org/jira/browse/SENTRY-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270724#comment-14270724
 ] 

Dapeng Sun edited comment on SENTRY-599 at 1/9/15 7:58 AM:
-----------------------------------------------------------

About the change of 90s: when we stop thrift server, the {{serve()}} of 
{{TThreadPoolServer}} also will wait 60s for 
{{executorService.awaitTermination()}}
[TThreadPoolServer.java | 
https://github.com/apache/thrift/blob/5b0296064845240006a66e94037c90c0a6aad87f/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L219]

And many thanks to @[~colinma] for helping to investigate the issue!


was (Author: dapengsun):
About the change of 90s: when we stop thrift server, the {{serve()}} of 
{{TThreadPoolServer}} also will wait 60s for 
{{executorService.awaitTermination()}}
[TThreadPoolServer.java | 
https://github.com/apache/thrift/blob/5b0296064845240006a66e94037c90c0a6aad87f/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L219]

And many thank @[~colinma] for helping to investigate the issue!

> Sentry service may report incorrect status when service is restarting
> ---------------------------------------------------------------------
>
>                 Key: SENTRY-599
>                 URL: https://issues.apache.org/jira/browse/SENTRY-599
>             Project: Sentry
>          Issue Type: Bug
>            Reporter: Dapeng Sun
>            Assignee: Dapeng Sun
>         Attachments: SENTRY-599.001.patch, SENTRY-599.002.patch, 
> SENTRY-599.003.patch, SENTRY-599.004.patch, TestSingleThreadExecutor.java
>
>
> When sentry service is restarting using same configuration and context.  
> {{server.isRunning()}} will report incorrect status.
> The root cause is {{finally}} may run after {{future = 
> serviceExecutor.submit(this);}}, the status will be {{NOT_STARTED}} even the 
> thrift server is started



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to