[ 
https://issues.apache.org/jira/browse/SENTRY-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280511#comment-14280511
 ] 

Prasad Mujumdar commented on SENTRY-494:
----------------------------------------

[~colin_mjj] Thanks for updating the patch.
Regarding the tests, do we have to use the transaction manager ? I guess the 
legacy behavior of locks should still work without that. From the authorization 
point, we just want to test LOCK and UNLOCK statements. Hardcoding the hive 
metastore schema in the test makes it complex and maintenance headache for 
upgrades. Is it possible to just test LOCK and UNLOCK statement as legacy Hive 
behavior ?
(Also a minor nit, the pom files has bonecp version 0.8.0.RELEASE which is 
different from the one defined in the top level pom. You might want to remove 
the version from the child pom).


> UNLOCK TABLE is not allowed
> ---------------------------
>
>                 Key: SENTRY-494
>                 URL: https://issues.apache.org/jira/browse/SENTRY-494
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.3.0
>         Environment: Sentry 1.3.0 CDH5.1.2
>            Reporter: Grisha Trubetskoy
>            Assignee: Colin Ma
>         Attachments: SENTRY-494.001.patch, SENTRY-494.002.patch, 
> SENTRY-494.003.patch
>
>
> {code}
> UNLOCK TABLE grisha_test;
> Error: Error while compiling statement: FAILED: SemanticException No valid 
> privileges (state=42000,code=40000)
> {code}
> Unless I'm missing something, there is no way to specify an unlock privilege 
> in Sentry.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to