[ 
https://issues.apache.org/jira/browse/SENTRY-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358112#comment-14358112
 ] 

Xiaomeng Huang commented on SENTRY-577:
---------------------------------------

Thanks [~guoquan] for reviewing!
Committed to trunk:
commit f5a99962ab8fb8a333d270f4b5059b2c791293b1
Author: Huang Xiaomeng <[email protected]>
Date:   Thu Mar 12 12:42:05 2015 +0800

    SENTRY-577: Orphan cleaner should remove privilege is not ALL, SELECT or 
INSERT (Xiaomeng Huang, reviewed by Guoquan Shen)

> Orphan cleaner should remove privilege is not ALL, SELECT or INSERT
> -------------------------------------------------------------------
>
>                 Key: SENTRY-577
>                 URL: https://issues.apache.org/jira/browse/SENTRY-577
>             Project: Sentry
>          Issue Type: Bug
>            Reporter: Xiaomeng Huang
>            Assignee: Xiaomeng Huang
>         Attachments: SENTRY-577.001.patch, SENTRY-577.002.patch
>
>
> I notice recently there is a orphan privilege cleanup thread to remove 
> privilege from role. So it is a bug when we remove privilege that is not in 
> {ALL,SELECT,INSERT}
> {code}
>        // if this privilege is not ALL, SELECT nor INSERT,
>        // we will revoke it from role directly
>        mPrivilege.removeRole(mRole);
> +      privCleaner.incPrivRemoval();
>        pm.makePersistent(mPrivilege);
>      }
>    }
> {code}
> This is a follow up bug of SENTRY-549



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to