[
https://issues.apache.org/jira/browse/SENTRY-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493621#comment-14493621
]
Dapeng Sun commented on SENTRY-537:
-----------------------------------
Hi Colin, the patch looks good to me, some minor comments below:
* We may need to close the context at
{{verifyInvalidConfigurationException(properties)}}
* Do you think it is possible to open a new ticket at review board?
> Refactor AbstractTestWithHiveServer to cut down some test cases runtime
> -----------------------------------------------------------------------
>
> Key: SENTRY-537
> URL: https://issues.apache.org/jira/browse/SENTRY-537
> Project: Sentry
> Issue Type: Sub-task
> Reporter: Xiaomeng Huang
> Assignee: Colin Ma
> Fix For: 1.6.0
>
> Attachments: SENTRY-537.001.patch, SENTRY-537.002.patch,
> SENTRY-537.003.patch, SENTRY-537.004.patch
>
>
> Some test classes which extends AbstractTestWithHiveServer run every test to
> setup hiveserver and create context, please see TestServerConfiguration,
> every test will setup hiveserver. I think we can start hiveserver in
> beforeClass to reduce test case runtime.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
