[ 
https://issues.apache.org/jira/browse/SENTRY-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634668#comment-14634668
 ] 

Dapeng Sun commented on SENTRY-755:
-----------------------------------

Hi [~sravya],

I think the change is okay. but it seems Unit Tests is failed in my local 
environment, I just used the following command:
{{mvn clean  test -Dtest=TestHDFSIntegration#testColumnPrivileges 
-DfailIfNoTests=false}}

Nit: Could we change {{privilege.isSetPrivilegeScope() && 
privilege.getPrivilegeScope().equalsIgnoreCase("COLUMN")}} to 
{{"COLUMN".equalsIgnoreCase(privilege.getPrivilegeScope())}}

> HDFS access of data files should be disabled for user with privileges only on 
> some columns
> ------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-755
>                 URL: https://issues.apache.org/jira/browse/SENTRY-755
>             Project: Sentry
>          Issue Type: New Feature
>          Components: Hdfs Plugin, Hive Plugin
>    Affects Versions: 1.5.0
>            Reporter: Sravya Tirukkovalur
>            Assignee: Sravya Tirukkovalur
>             Fix For: 1.6.0
>
>         Attachments: SENTRY-755-test.patch, SENTRY-755.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to