[ https://issues.apache.org/jira/browse/SENTRY-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724776#comment-14724776 ]
Hadoop QA commented on SENTRY-841: ---------------------------------- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12753082/SENTRY-841.patch against master. {color:green}Overall:{color} +1 all checks pass {color:green}SUCCESS:{color} all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/831/console This message is automatically generated. > Revoke on SERVER scope breaks Client API, allows any string to be passed in > --------------------------------------------------------------------------- > > Key: SENTRY-841 > URL: https://issues.apache.org/jira/browse/SENTRY-841 > Project: Sentry > Issue Type: Bug > Components: Service > Affects Versions: 1.6.0 > Reporter: Lenni Kuff > Assignee: Ryan P > Attachments: SENTRY-841.patch, SENTRY-841.patch, SENTRY-841.patch > > > Revoke on server scope change the Java API in an incompatible way (added a > new parameter). We need to fix the client API to have an overload for revoke > which defaults to "ALL" privileges if nothing is specified. > Additionally, it looks like any string can be passed in for the "action" > field of the new API. We should validate that the action is valid - "SELECT", > "INSERT", or "ALL". -- This message was sent by Atlassian JIRA (v6.3.4#6332)