[ 
https://issues.apache.org/jira/browse/SENTRY-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006265#comment-15006265
 ] 

Dapeng Sun edited comment on SENTRY-958 at 11/16/15 6:38 AM:
-------------------------------------------------------------

Hi [~coheigea], thank you for your patch.

About JDK 1.8, I used travis-ci to run the unit 
tests,https://travis-ci.org/sundapeng/incubator-sentry/jobs/90891322#L9243, it 
seems there is another error at JDK 1.8, have you fixed it in your environment?

About this change, I think we'd better to not depend on the sort of Collection, 
since there are only two actions here, can we use whether actions contain READ 
and WRITE to verify the action list?


was (Author: dapengsun):
Hi [~coheigea], thank you for your patch.

About JDK 1.8, I used travis-ci to run the unit 
tests,https://travis-ci.org/sundapeng/incubator-sentry/jobs/90891322#L9243, it 
seems there is another error at JDK 1.8, did you have fixed it in you 
environment?

About this change, I think we'd better to not depend on the sort of Collection, 
since there are only two actions here, can we use whether actions contain READ 
and WRITE to verify the action list?

> TestGrantPrivilege fails on JDK8
> --------------------------------
>
>                 Key: SENTRY-958
>                 URL: https://issues.apache.org/jira/browse/SENTRY-958
>             Project: Sentry
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 1.7.0
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>            Priority: Trivial
>             Fix For: 1.7.0
>
>         Attachments: SENTRY-958.patch
>
>
> The Sqoop test TestGrantPrivilege fails when run on JDK8. This is because it 
> assumes an order on the privileges returned by 
> client.getPrivilegesByPrincipal that may not necessarily exist.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to