[
https://issues.apache.org/jira/browse/SENTRY-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044317#comment-15044317
]
Colin Ma commented on SENTRY-972:
---------------------------------
[~lskuff], I compared the committed patch and the patch attached here
(SENTRY-972.patch), they are different.
The committed patch deleted the file: sentry-tests-hive/testutil/hadoop
But the patch SENTRY-972.patch added the file:
sentry-tests-hive/src/test/resources/hadoop
Some tests are failed now, can you help to check, thanks.
> Include sentry-tests-hive hadoop test script in maven project
> -------------------------------------------------------------
>
> Key: SENTRY-972
> URL: https://issues.apache.org/jira/browse/SENTRY-972
> Project: Sentry
> Issue Type: Improvement
> Components: Test
> Reporter: Colm O hEigeartaigh
> Assignee: Colm O hEigeartaigh
> Priority: Trivial
> Fix For: 1.7.0
>
> Attachments: SENTRY-972.patch
>
>
> Currently, the sentry-tests-hive module ships a hadoop script in testutils,
> and uses the maven-antrun-plugin to write and execute a script to copy the
> hadoop file into "target" and make it executable.
> A better approach would be just to include the script in src/test/resources,
> and change the permission in the test code to make it executable. This avoids
> the use of the antrun-plugin + executing a bash script, as well as including
> the script in the standard maven project structure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
