[ 
https://issues.apache.org/jira/browse/SENTRY-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194753#comment-15194753
 ] 

Colin Ma edited comment on SENTRY-1071 at 3/15/16 5:53 AM:
-----------------------------------------------------------

[~dapengsun], the thrift interface should be generated by maven build. I agree 
to update them as the same as generated by maven build, even there has some 
white spaces.
+1, pending on pre-commit.


was (Author: colinma):
[~dapengsun], the thrift interface should be generated by maven build. I agree 
to update them as the same as generated by maven build.
+1, pending on pre-commit.

> Update thrift gen-file with maven plugin
> ----------------------------------------
>
>                 Key: SENTRY-1071
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1071
>             Project: Sentry
>          Issue Type: Bug
>            Reporter: Dapeng Sun
>            Assignee: Dapeng Sun
>         Attachments: SENTRY-1071.001.patch
>
>
> Using {{mvn clean install -DskipTests -Pthriftif -Dthrift.home=...}} to 
> build, I found the following classes are updated, I also check my {{thrift 
> -version}} is {{Thrift version 0.9.0}},
> {noformat}
>  M 
> sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/SentryHDFSService.java
>  M 
> sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TAuthzUpdateResponse.java
>  M 
> sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathChanges.java
>  M 
> sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathEntry.java
>  M 
> sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsDump.java
>  M 
> sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPathsUpdate.java
>  M 
> sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPermissionsUpdate.java
>  M 
> sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegeChanges.java
>  M 
> sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TRoleChanges.java
>  M 
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyService.java
>  M 
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesByAuthRequest.java
>  M 
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesByAuthResponse.java
>  M 
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TSentryPrivilegeMap.java
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to