This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git
commit fc0a37069756ada579e0f7b4b81f0145c3d6d480 Author: donglzh168 <1473442...@qq.com> AuthorDate: Sat Jan 6 14:28:20 2018 +0800 [SCB-180] Hystrixcommand setter not set by dynamic configuration --- .../test/java/io/servicecomb/bizkeeper/TestBizkeeperHandler.java | 4 ++-- .../servicecomb/bizkeeper/TestHystrixPropertiesStrategyExt.java | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/handlers/handler-bizkeeper/src/test/java/io/servicecomb/bizkeeper/TestBizkeeperHandler.java b/handlers/handler-bizkeeper/src/test/java/io/servicecomb/bizkeeper/TestBizkeeperHandler.java index a8b646d..bf1c1ea 100644 --- a/handlers/handler-bizkeeper/src/test/java/io/servicecomb/bizkeeper/TestBizkeeperHandler.java +++ b/handlers/handler-bizkeeper/src/test/java/io/servicecomb/bizkeeper/TestBizkeeperHandler.java @@ -105,7 +105,7 @@ public class TestBizkeeperHandler extends BizkeeperHandler { } catch (Exception e) { validAssert = false; } - Assert.assertFalse(validAssert); + Assert.assertTrue(validAssert); } @Override @@ -145,7 +145,7 @@ public class TestBizkeeperHandler extends BizkeeperHandler { System.setProperty("cse.fallbackpolicy.Group_Name.testHandleForceReturnnull.policy", "returnnull"); bizkeeperHandler.handle(invocation, f -> { Assert.assertTrue(f.isSuccessed()); - Assert.assertEquals(null, (Object) f.getResult()); + Assert.assertEquals(null, f.getResult()); }); } } diff --git a/handlers/handler-bizkeeper/src/test/java/io/servicecomb/bizkeeper/TestHystrixPropertiesStrategyExt.java b/handlers/handler-bizkeeper/src/test/java/io/servicecomb/bizkeeper/TestHystrixPropertiesStrategyExt.java index d127906..b0cd624 100644 --- a/handlers/handler-bizkeeper/src/test/java/io/servicecomb/bizkeeper/TestHystrixPropertiesStrategyExt.java +++ b/handlers/handler-bizkeeper/src/test/java/io/servicecomb/bizkeeper/TestHystrixPropertiesStrategyExt.java @@ -70,12 +70,12 @@ public class TestHystrixPropertiesStrategyExt { Assert.assertFalse(commandPro.circuitBreakerForceClosed().get()); Assert.assertFalse(commandPro.circuitBreakerForceOpen().get()); Assert.assertEquals(Integer.valueOf(20), commandPro.circuitBreakerRequestVolumeThreshold().get()); - Assert.assertEquals(Integer.valueOf(5000), commandPro.circuitBreakerSleepWindowInMilliseconds().get()); - Assert.assertEquals(Integer.valueOf(10), commandPro.executionIsolationSemaphoreMaxConcurrentRequests().get()); + Assert.assertEquals(Integer.valueOf(15000), commandPro.circuitBreakerSleepWindowInMilliseconds().get()); + Assert.assertEquals(Integer.valueOf(1000), commandPro.executionIsolationSemaphoreMaxConcurrentRequests().get()); Assert.assertTrue(commandPro.executionIsolationThreadInterruptOnTimeout().get()); Assert.assertEquals(null, commandPro.executionIsolationThreadPoolKeyOverride().get()); - Assert.assertEquals(Integer.valueOf(1000), commandPro.executionTimeoutInMilliseconds().get()); - Assert.assertTrue(commandPro.executionTimeoutEnabled().get()); + Assert.assertEquals(Integer.valueOf(30000), commandPro.executionTimeoutInMilliseconds().get()); + Assert.assertFalse(commandPro.executionTimeoutEnabled().get()); Assert.assertEquals(Integer.valueOf(10), commandPro.fallbackIsolationSemaphoreMaxConcurrentRequests().get()); Assert.assertTrue(commandPro.fallbackEnabled().get()); } -- To stop receiving notification emails like this one, please contact "commits@servicecomb.apache.org" <commits@servicecomb.apache.org>.