liubao68 commented on a change in pull request #714: [SCB-579] fix
NullPointerException when consumer upload null file
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/714#discussion_r189174251
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/RestClientRequestImpl.java
##########
@@ -169,6 +173,10 @@ private void attachFile(String boundary,
Iterator<Entry<String, Part>> uploadsIt
// because pojo consumer not easy to set name to part
String name = entry.getKey();
Part part = entry.getValue();
+ if (null == part) {
Review comment:
Since uploads do not have null entries, this is redundant null check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
