liubao68 commented on a change in pull request #727: [SCB-607] Accesslog 
support invocation context item
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/727#discussion_r190806272
 
 

 ##########
 File path: 
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
 ##########
 @@ -249,4 +265,21 @@ protected void onExecuteHttpServerFiltersFinish(Response 
response, Throwable e)
       invocation.onFinish(response);
     }
   }
+
+  public void setAfterCreateInvocationHandler(
 
 Review comment:
   Maybe create a new protected method is better.
   protected void afterCreateInvocation()
   protected void beforeCreateInvocation()
   protected void createInvocation()
   
    And we can implement it in RestProducerInvocation, e.g
   RestProducerInvocation invo = new RestProducerInvocation.java(RoutingContext 
context)
   ..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to