This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch SCB-555 in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-saga.git
commit f6d4cd9eb71af30d52387e7800dd240be2c0ec9c Author: wuzunqian <wuzunq...@msn.com> AuthorDate: Thu May 10 16:50:23 2018 +0800 fix result events unorder --- .../acceptance/dubbodemo/DubboDemoStepdefs.java | 25 +++++++++++++--------- .../resources/AExceptionWhenAb_scenario.feature | 2 +- .../test/resources/AbAc_success_scenario.feature | 2 +- .../test/resources/AbBc_success_scenario.feature | 2 +- .../src/test/resources/Ab_success_scenario.feature | 2 +- .../resources/BExceptionWhenAb_scenario.feature | 2 +- .../resources/CExceptionWhenAbAc_scenario.feature | 2 +- .../resources/CExceptionWhenAbBc_scenario.feature | 2 +- 8 files changed, 22 insertions(+), 17 deletions(-) diff --git a/acceptance-tests/acceptance-dubbo-demo/src/test/java/org/apache/servicecomb/saga/acceptance/dubbodemo/DubboDemoStepdefs.java b/acceptance-tests/acceptance-dubbo-demo/src/test/java/org/apache/servicecomb/saga/acceptance/dubbodemo/DubboDemoStepdefs.java index af6b7d1..80e503e 100644 --- a/acceptance-tests/acceptance-dubbo-demo/src/test/java/org/apache/servicecomb/saga/acceptance/dubbodemo/DubboDemoStepdefs.java +++ b/acceptance-tests/acceptance-dubbo-demo/src/test/java/org/apache/servicecomb/saga/acceptance/dubbodemo/DubboDemoStepdefs.java @@ -77,16 +77,21 @@ public class DubboDemoStepdefs implements En { }); Then("^Alpha records the following events$", (DataTable dataTable) -> { - Consumer<Map<String, Object>[]> sortAndColumnStrippingConsumer = dataMap -> { - //sort first - Arrays.sort(dataMap, (o1, o2) -> { - Integer id1 = (Integer)o1.get("surrogateId"); - Integer id2 = (Integer)o2.get("surrogateId"); - if(id1 == null || id2 == null) return 0; - return id1.compareTo(id2); - }); + Consumer<Map<String, Object>[]> sortAndColumnStrippingConsumer = dataMaps -> { + //blur match: service for sagaEndedEvent may be unable to que + for(Map<String, Object> dataMap : dataMaps){ + LOG.info(dataMap.toString()); + if(dataMap.values().contains("SagaEndedEvent")){ + for(String key : dataMap.keySet()){ + if("SagaEndedEvent".equals(dataMap.get(key))){ + dataMap.put("serviceName", "*"); + break; + } + } + } + } //strip columns - for (Map<String, Object> map : dataMap) + for (Map<String, Object> map : dataMaps) map.keySet().retainAll(dataTable.topCells()); }; @@ -131,7 +136,7 @@ public class DubboDemoStepdefs implements En { } LOG.info("Retrieved data {} from service", actualMaps); - dataTable.diff(DataTable.create(actualMaps)); + dataTable.unorderedDiff(DataTable.create(actualMaps)); } @SuppressWarnings("unchecked") diff --git a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/AExceptionWhenAb_scenario.feature b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/AExceptionWhenAb_scenario.feature index 2be4378..5622006 100644 --- a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/AExceptionWhenAb_scenario.feature +++ b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/AExceptionWhenAb_scenario.feature @@ -30,7 +30,7 @@ Feature: Alpha records transaction events | serviceb | TxEndedEvent | | servicea | TxAbortedEvent | | serviceb | TxCompensatedEvent | - | serviceb | SagaEndedEvent | + | * | SagaEndedEvent | And servicea success update status | service | vstatus | diff --git a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/AbAc_success_scenario.feature b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/AbAc_success_scenario.feature index 9ba638e..bb8ed91 100644 --- a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/AbAc_success_scenario.feature +++ b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/AbAc_success_scenario.feature @@ -32,7 +32,7 @@ Feature: Alpha records transaction events | servicec | TxStartedEvent | | servicec | TxEndedEvent | | servicea | TxEndedEvent | - | servicea | SagaEndedEvent | + | * | SagaEndedEvent | And servicea success update status | service | vstatus | diff --git a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/AbBc_success_scenario.feature b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/AbBc_success_scenario.feature index 1af54fc..4d3739e 100644 --- a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/AbBc_success_scenario.feature +++ b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/AbBc_success_scenario.feature @@ -32,7 +32,7 @@ Feature: Alpha records transaction events | servicec | TxEndedEvent | | serviceb | TxEndedEvent | | servicea | TxEndedEvent | - | servicea | SagaEndedEvent | + | * | SagaEndedEvent | And servicea success update status | service | vstatus | diff --git a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/Ab_success_scenario.feature b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/Ab_success_scenario.feature index 3313bb4..b3b1c6d 100644 --- a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/Ab_success_scenario.feature +++ b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/Ab_success_scenario.feature @@ -29,7 +29,7 @@ Feature: Alpha records transaction events | serviceb | TxStartedEvent | | serviceb | TxEndedEvent | | servicea | TxEndedEvent | - | servicea | SagaEndedEvent | + | * | SagaEndedEvent | And servicea success update status | service | vstatus | diff --git a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/BExceptionWhenAb_scenario.feature b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/BExceptionWhenAb_scenario.feature index 65d1d8f..d0e295e 100644 --- a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/BExceptionWhenAb_scenario.feature +++ b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/BExceptionWhenAb_scenario.feature @@ -29,7 +29,7 @@ Feature: Alpha records transaction events | serviceb | TxStartedEvent | | serviceb | TxAbortedEvent | | servicea | TxAbortedEvent | - | servicea | SagaEndedEvent | + | * | SagaEndedEvent | And servicea success update status | service | vstatus | diff --git a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/CExceptionWhenAbAc_scenario.feature b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/CExceptionWhenAbAc_scenario.feature index 689b4f1..9c3bdc9 100644 --- a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/CExceptionWhenAbAc_scenario.feature +++ b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/CExceptionWhenAbAc_scenario.feature @@ -33,7 +33,7 @@ Feature: Alpha records transaction events | servicec | TxAbortedEvent | | servicea | TxAbortedEvent | | serviceb | TxCompensatedEvent | - | serviceb | SagaEndedEvent | + | * | SagaEndedEvent | And servicea success update status | service | vstatus | diff --git a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/CExceptionWhenAbBc_scenario.feature b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/CExceptionWhenAbBc_scenario.feature index 54fa1f9..065a0cf 100644 --- a/acceptance-tests/acceptance-dubbo-demo/src/test/resources/CExceptionWhenAbBc_scenario.feature +++ b/acceptance-tests/acceptance-dubbo-demo/src/test/resources/CExceptionWhenAbBc_scenario.feature @@ -32,7 +32,7 @@ Feature: Alpha records transaction events | servicec | TxAbortedEvent | | serviceb | TxAbortedEvent | | servicea | TxAbortedEvent | - | servicea | SagaEndedEvent | + | * | SagaEndedEvent | And servicea success update status | service | vstatus | -- To stop receiving notification emails like this one, please contact ningji...@apache.org.