WillemJiang commented on a change in pull request #728: [SCB-589] Consumer
producer upgrade unordered
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/728#discussion_r191044374
##########
File path:
common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/definition/ProtobufManager.java
##########
@@ -45,13 +50,28 @@
private ProtobufManager() {
}
+ /**
+ * only for app classloader
+ * @return
+ */
+ public static ScopedProtobufSchemaManager
getDefaultScopedProtobufSchemaManager() {
+ return defaultScopedProtobufSchemaManager;
+ }
+
public static OperationProtobuf getOrCreateOperation(OperationMeta
operationMeta) throws Exception {
- OperationProtobuf operationProtobuf =
operationMeta.getExtData(ProtobufManager.EXT_ID);
+ OperationProtobuf operationProtobuf = operationMeta.getExtData(EXT_ID);
Review comment:
if the ExtData is not volatile, and there are two thread a modify it, you
may face some issue here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
