zhengyangyong commented on a change in pull request #729: [SCB-562] fix NPE
when had empty interface (not have any method)
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/729#discussion_r191341145
##########
File path:
core/src/main/java/org/apache/servicecomb/core/definition/SchemaMeta.java
##########
@@ -83,6 +83,12 @@ public String getPackageName() {
}
private void initOperations() {
+ if (swagger.getPaths() == null) {
+ LOGGER.error(swagger.getInfo().getTitle() + " with path " +
swagger.getBasePath()
Review comment:
so, we can process this issue two way :
1. throw a ServiceCombException exception, not NPE
2. Give a error log to let user know it is not an appropriate practice and
fix as quick as possible, and let service go
This issue come from user report, he want fill interface later, which is
better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
