wujimin commented on a change in pull request #731: [SCB-617] Graceful shutdown
with standalone tomcat
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/731#discussion_r192278085
##########
File path:
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
##########
@@ -109,13 +109,15 @@
private ConfigCenterConfigurationSourceImpl.UpdateHandler updateHandler;
- private static ClientPoolManager<HttpClientWithContext> clientMgr;
+ private ClientPoolManager<HttpClientWithContext> clientMgr;
private boolean isWatching = false;
- private static final ServiceLoader<AuthHeaderProvider> authHeaderProviders =
+ private final ServiceLoader<AuthHeaderProvider> authHeaderProviders =
ServiceLoader.load(AuthHeaderProvider.class);
+ private URIConst uriConst = new URIConst();
Review comment:
not necessary
only use once here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
