liubao68 commented on a change in pull request #741: [SCB-625] ProduceProcessor
use SPI to support extends
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/741#discussion_r194624585
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceProcessorManager.java
##########
@@ -17,24 +17,38 @@
package org.apache.servicecomb.common.rest.codec.produce;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
import javax.ws.rs.core.MediaType;
import org.apache.servicecomb.foundation.common.RegisterManager;
+import org.apache.servicecomb.foundation.common.utils.SPIServiceUtils;
public final class ProduceProcessorManager extends RegisterManager<String,
ProduceProcessor> {
+ private static final List<ProduceProcessor> produceProcessor =
SPIServiceUtils.getAllService(ProduceProcessor.class);
Review comment:
Maybe use getSortedService is better, although they are same. Because
following codes depends on order
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
