liubao68 commented on a change in pull request #767: [SCB-662]Using
cse/servicecomb duplicate key will get list of values
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/767#discussion_r195391079
##########
File path:
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
##########
@@ -171,7 +171,14 @@ private static void
duplicateServiceCombConfigToCse(AbstractConfiguration source
}
String cseKey = CONFIG_CSE_PREFIX + key.substring(key.indexOf(".") + 1);
- source.addProperty(cseKey, source.getProperty(key));
+ if (!source.containsKey(cseKey)) {
+ source.addProperty(cseKey, source.getProperty(key));
+ } else {
+ LOGGER
+ .warn(
Review comment:
"stop working" can not be applied because we may configure some default
values using cse or servicecomb, if doing this users code have to change to
work properly. We can't do this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
