wujimin commented on a change in pull request #767: [SCB-662]Using
cse/servicecomb duplicate key will get list of values
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/767#discussion_r195403429
##########
File path:
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
##########
@@ -171,7 +171,14 @@ private static void
duplicateServiceCombConfigToCse(AbstractConfiguration source
}
String cseKey = CONFIG_CSE_PREFIX + key.substring(key.indexOf(".") + 1);
- source.addProperty(cseKey, source.getProperty(key));
+ if (!source.containsKey(cseKey)) {
+ source.addProperty(cseKey, source.getProperty(key));
Review comment:
source.setProperty is better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
