liubao68 commented on a change in pull request #803:  [SCB-706]change filters 
to discovery filters and support invocation based filters
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/803#discussion_r202225963
 
 

 ##########
 File path: 
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/ServiceCombServer.java
 ##########
 @@ -79,29 +69,16 @@ public String getHost() {
     return endpoint.getEndpoint();
   }
 
-  public void clearContinuousFailure() {
-    continuousFailureCount.set(0);
-  }
-
-  public void incrementContinuousFailureCount() {
-    if (continuousFailureCount.get() < Integer.MAX_VALUE) {
-      continuousFailureCount.incrementAndGet();
-    }
-  }
-
-  public int getCountinuousFailureCount() {
-    return continuousFailureCount.get();
-  }
-
+  // take endpoints that belongs to same instance as same server
   public boolean equals(Object o) {
-    if (o instanceof CseServer) {
-      return this.getHost().equals(((CseServer) o).getHost());
+    if (o instanceof ServiceCombServer) {
 
 Review comment:
   DiscoveryFilter sees MicroserviceInstance, not Endpoint. And the health 
check is also to MicroserviceInstance, not Endpoint. I modified server same 
when MicroserviceInstance is same to make all these place consistence to each 
other.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to